loki icon indicating copy to clipboard operation
loki copied to clipboard

Fix links to configuration page

Open fjvela opened this issue 3 years ago • 2 comments

What this PR does / why we need it: Fix links to configuration page:

  • kafka
  • Cloudflare

fjvela avatar Sep 15 '22 05:09 fjvela

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 15 '22 05:09 CLAassistant

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Sep 15 '22 05:09 grafanabot

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Nov 02 '22 19:11 grafanabot

@jdbaldry @osg-grafana @DylanGuedes can you take a look?

fjvela avatar Nov 27 '22 10:11 fjvela

Apologies for the delay in reviewing this. I really appreciate the fixes to the links because now we can have link checking in our local development.

I've added one nit and will let @DylanGuedes and @osg-grafana re-review so they can remove their request for changes if they are happy and we can get this merged.

One note that we should just double check. Given the age of this branch, it might make sense to sync with main, either by rebase or merge, so that we can ensure nothing has moved around under us.

jdbaldry avatar Nov 29 '22 12:11 jdbaldry

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Nov 29 '22 17:11 grafanabot

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Dec 11 '22 10:12 grafanabot

@osg-grafana would you mind re-reviewing this for your requested changes?

jdbaldry avatar Dec 12 '22 12:12 jdbaldry

@osg-grafana could you take a look to the PR?

Thanks.

fjvela avatar Dec 20 '22 06:12 fjvela

I've dismissed @osg-grafana's request for changes as I believe they have been addressed and they are currently OOO until the new year.

@grafana/loki-squad is anyone able to merge this?

The CI failure appears to be unrelated.

jdbaldry avatar Dec 20 '22 11:12 jdbaldry

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Dec 20 '22 12:12 grafanabot

Crazy... I don't know why but some of them doesn't work... (facepalm)

fjvela avatar Dec 20 '22 17:12 fjvela