loki icon indicating copy to clipboard operation
loki copied to clipboard

lambda-promtail-: fix parse kinesis timestamp

Open lfelipevaca opened this issue 3 years ago • 3 comments

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

  • [x] Documentation added
  • [x] Tests updated
  • [ ] Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

lfelipevaca avatar Sep 14 '22 16:09 lfelipevaca

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 14 '22 16:09 CLAassistant

this change solves the problem described in the following issue

https://github.com/grafana/loki/issues/7159

lfelipevaca avatar Sep 14 '22 16:09 lfelipevaca

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Sep 14 '22 16:09 grafanabot

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.

stale[bot] avatar Nov 02 '22 07:11 stale[bot]

@lfelipevaca Thanks for this contribution. There is a unit test for parsing Kinesis events. Can you add a check for this change?

MichelHollands avatar Nov 07 '22 10:11 MichelHollands