loki icon indicating copy to clipboard operation
loki copied to clipboard

rename shipper package to boltdbshipper for clarity

Open sandeepsukhani opened this issue 2 years ago • 3 comments

What this PR does / why we need it: The package for boltdb-shipper index client was initially named shipper to be concise. However, we now have indexshipper package taking care of the shipping part and the shipper only contains code for reading/writing boltdb files for boltdb-shipper index client. To keep things clear, it would be good to rename shipper to boltdbshipper.

sandeepsukhani avatar Jul 22 '22 09:07 sandeepsukhani

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Jul 22 '22 09:07 grafanabot

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Jul 29 '22 06:07 grafanabot

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.

stale[bot] avatar Sep 21 '22 06:09 stale[bot]

@sandeepsukhani Do you wanna update this PR?

chaudum avatar Oct 10 '22 11:10 chaudum

@sandeepsukhani would you mind updating your branch?

jeschkies avatar Jan 10 '23 13:01 jeschkies

@sandeepsukhani should we drop this?

jeschkies avatar Feb 24 '23 16:02 jeschkies

@sandeepsukhani This is obsolete now, right?

chaudum avatar Feb 27 '23 09:02 chaudum

@chaudum let's close this. Sandeep can always reopen the PR.

jeschkies avatar Feb 27 '23 13:02 jeschkies