loki
loki copied to clipboard
feat: add keep_firing_for support to alerting rules
What this PR does / why we need it:
Adding the keep_firing_for in alerting rule.
Which issue(s) this PR fixes: Fixes #7450
Special notes for your reviewer:
I copied everything from https://github.com/grafana/mimir/pull/4099 thanks to @pracucci.
Checklist
- [x] Reviewed the
CONTRIBUTING.mdguide (required) - [ ] Documentation added
- [x] Tests updated
- [ ] Title matches the required conventional commits format, see here
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
- [ ] Changes that require user attention or interaction to upgrade are documented in
docs/sources/setup/upgrade/_index.md - [ ] For Helm chart changes bump the Helm chart version in
production/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR - [ ] If the change is deprecating or removing a configuration option, update the
deprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR
@cyriltovena @dannykopping what do you think about this ?
we'd also find this useful!
Any feedback grafana team ?
Still no response about this PR ?
This would be such a valuable addition to Loki!
Any feedback grafana team ?
may @dannykopping could help for the review ?
hi, any review ?
+1 for this feature in Loki
@chaudum @cyriltovena @dannykopping any feedback regarding this feature please?
+1 for this feature in Loki