loki icon indicating copy to clipboard operation
loki copied to clipboard

feat: support ruler sidecar in singleBinary mode

Open okozachenko1203 opened this issue 1 year ago • 4 comments
trafficstars

What this PR does / why we need it: support ruler sidecar in singleBinary mode

Which issue(s) this PR fixes: Fixes #10967

Special notes for your reviewer:

Checklist

  • [ ] Reviewed the CONTRIBUTING.md guide (required)
  • [ ] Documentation added
  • [ ] Tests updated
  • [ ] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ ] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

okozachenko1203 avatar Jul 18 '24 12:07 okozachenko1203

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 18 '24 13:07 CLAassistant

I would also need & love this feature!

3deep5me avatar Jul 26 '24 14:07 3deep5me

Hi @okozachenko1203, i think you need to sign the CLA that the PR can be proceeded.

3deep5me avatar Jul 29 '24 08:07 3deep5me

would be great to have this resolved :)

tyriis avatar Aug 21 '24 20:08 tyriis

any chance to get this merged?

jazzlyn avatar Sep 17 '24 20:09 jazzlyn

Any updates on this?

janisii avatar Sep 23 '24 07:09 janisii

Thanks for merging this!

Just a notice, please update the Chart.yaml in the next time. With this MR semantic versioning has been eliminated.
I had a fixed Chart-Version in ArgoCD and out of nowhere a new sidecar with new mounts appeared in my deployments.

3deep5me avatar Sep 30 '24 14:09 3deep5me