loki
loki copied to clipboard
feat: support ruler sidecar in singleBinary mode
What this PR does / why we need it: support ruler sidecar in singleBinary mode
Which issue(s) this PR fixes: Fixes #10967
Special notes for your reviewer:
Checklist
- [ ] Reviewed the
CONTRIBUTING.mdguide (required) - [ ] Documentation added
- [ ] Tests updated
- [ ] Title matches the required conventional commits format, see here
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
- [ ] Changes that require user attention or interaction to upgrade are documented in
docs/sources/setup/upgrade/_index.md - [ ] For Helm chart changes bump the Helm chart version in
production/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR - [ ] If the change is deprecating or removing a configuration option, update the
deprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR
I would also need & love this feature!
Hi @okozachenko1203, i think you need to sign the CLA that the PR can be proceeded.
would be great to have this resolved :)
any chance to get this merged?
Any updates on this?
Thanks for merging this!
Just a notice, please update the Chart.yaml in the next time. With this MR semantic versioning has been eliminated.
I had a fixed Chart-Version in ArgoCD and out of nowhere a new sidecar with new mounts appeared in my deployments.