loki icon indicating copy to clipboard operation
loki copied to clipboard

chore: adjusted SegmentWriter to the reader conversion

Open vlad-diachenko opened this issue 7 months ago • 1 comments

What this PR does / why we need it:

adjusted Client to convert SegmentWriter to the reader using the new function that uses buffer pool.

Special notes for your reviewer: addresses comment https://github.com/grafana/loki/pull/13315#discussion_r1653050375

Checklist

  • [ ] Reviewed the CONTRIBUTING.md guide (required)
  • [ ] Documentation added
  • [ ] Tests updated
  • [ ] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ ] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

vlad-diachenko avatar Jun 27 '24 12:06 vlad-diachenko