loki icon indicating copy to clipboard operation
loki copied to clipboard

feat(helm): Expose labels on volumeClaimTemplates

Open jkroepke opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

Velero resource filter based on labels.

https://velero.io/docs/main/resource-filtering/

In my use-case I want to exclude PVC from writer nodes (only used as WAL) from backup.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

jkroepke avatar Jun 25 '24 16:06 jkroepke

rebased

jkroepke avatar Jul 04 '24 17:07 jkroepke

updated

jkroepke avatar Jul 29 '24 07:07 jkroepke

merged from main

jkroepke avatar Aug 23 '24 16:08 jkroepke

@jkroepke could you please resolve the conflicts and take a look at my comments?

QuentinBisson avatar Jul 21 '25 13:07 QuentinBisson

Done 👍

jkroepke avatar Jul 23 '25 18:07 jkroepke

Nice work @jkroepke.

LGTM

QuentinBisson avatar Jul 23 '25 18:07 QuentinBisson

@JStickler we're good with this one

QuentinBisson avatar Jul 28 '25 07:07 QuentinBisson