loki
loki copied to clipboard
fix: querier address in SingleBinary mode
What this PR does / why we need it:
Fix loki.querierAddress
helper distributed check.
The current if statement effectively checks if the string is non-empty.
Which issue(s) this PR fixes: Fixes #12772 Fixes #12586
Special notes for your reviewer:
Checklist
- [X] Reviewed the
CONTRIBUTING.md
guide (required) - [ ] Documentation added
- [ ] Tests updated
- [X] Title matches the required conventional commits format, see here
-
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
-
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
- [ ] Changes that require user attention or interaction to upgrade are documented in
docs/sources/setup/upgrade/_index.md
- [X] For Helm chart changes bump the Helm chart version in
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PR - [ ] If the change is deprecating or removing a configuration option, update the
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR