loki icon indicating copy to clipboard operation
loki copied to clipboard

fix: Add value to helm chart to configure single binary service type

Open mkunkel opened this issue 9 months ago • 2 comments

What this PR does / why we need it: Allows the single binary Service type to be configured via values.yaml. In the case of an Ingress that relies on NodePort Services, the Ingress will not be able to reconcile, which can cause problems for other workloads sharing the Ingress group.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

mkunkel avatar May 23 '24 20:05 mkunkel