loki
loki copied to clipboard
fix: Fix incorrect sorting of chunks in bloom-filtered response since `ChunkRef.Cmp` method is used in reverse
The v1.ChunkRef.Cmp()
method is used in reverse, and this can lead to chunks in bloom filtered result be sorted in descending but not ascending
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
- [x] Reviewed the
CONTRIBUTING.md
guide (required) - [ ] Documentation added
- [ ] Tests updated
- [ ] Title matches the required conventional commits format, see here
-
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
-
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
- [ ] Changes that require user attention or interaction to upgrade are documented in
docs/sources/setup/upgrade/_index.md
- [ ] For Helm chart changes bump the Helm chart version in
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PR - [ ] If the change is deprecating or removing a configuration option, update the
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR