loki icon indicating copy to clipboard operation
loki copied to clipboard

Published 20 hours ago • verified publisher icon grafana

feat: Allows to configure client_max_body_size

Open satyamsundaram opened this issue 9 months ago • 2 comments

What this PR does / why we need it:

Adjusting client_max_body_size in Nginx allows us to fix this nginx error: client intended to send too large body.

Which issue(s) this PR fixes: Fixes #8736, #10521

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

satyamsundaram avatar May 09 '24 07:05 satyamsundaram

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 09 '24 07:05 CLAassistant

I've bumped the version. Let me know if there are any other changes required.

satyamsundaram avatar May 24 '24 02:05 satyamsundaram

Are there any updates on the merge for this one?

ursuciprian avatar Sep 27 '24 08:09 ursuciprian

I've fixed all merge conflicts. It can be merged now.

satyamsundaram avatar Sep 28 '24 07:09 satyamsundaram

@trevorwhitney Can you rerun the pipeline and potentially merge this ? This is currently a blocker for us to upgrade to loki 3.x

jarmd avatar Oct 22 '24 11:10 jarmd

Hi this merge appears to be on the helm Changelog currently on main branch for the Helm 6.15.0 (release 6.18.0 is the latest current release). https://github.com/grafana/loki/blob/f5b0fb6b998dc0a49cd36c0968862340c7e517bf/production/helm/loki/CHANGELOG.md

However I'm not actually finding any chart releases >=6.15.0 that include this variable for consumption.

What is the process here for changes to chart or has this change erroneously been removed or are the changelogs incorrect?

morganrowse avatar Oct 31 '24 12:10 morganrowse

yeah, it looks like the hem-ci is broken during the installation of the prometheus operator, which is breaking all helm releases. help in fixing it would be greatly appreciated!

trevorwhitney avatar Nov 01 '24 15:11 trevorwhitney