loki icon indicating copy to clipboard operation
loki copied to clipboard
verified publisher icon grafana

fix(helm): Fix wrong port name referenced for ingress NetworkPolicy

Open vholer opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

As described in issue #12906, the NetworkPolicy for ingress references wrong port name (http instead of current http-metrics), therefore if network policies are enabled, ingress traffic is dropped.

Which issue(s) this PR fixes: Fixes #12906

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [ ] Documentation added
  • [ ] Tests updated
  • [ ] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ ] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

vholer avatar May 07 '24 16:05 vholer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 07 '24 16:05 CLAassistant

This is an easy fix to the broken NetworkPolicies for Loki (still applies to recent Loki chart 6.12.0), esp. if I already provide a PR. I'm just wondering what's wrong, what can I do more to have this issue fixed. Any communication would be appreciated. Thank you.

vholer avatar Sep 16 '24 15:09 vholer

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

github-actions[bot] avatar Oct 17 '24 07:10 github-actions[bot]

Still an issue (chart 6.18.0, Loki 3.2.0).

vholer avatar Oct 17 '24 15:10 vholer