loki icon indicating copy to clipboard operation
loki copied to clipboard

fix: for the sharding-by-rule issue and the query hash block bug

Open tonychoe opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

We've found that sharding by rule did not work as expected and figured out the fixes.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [x] Tests updated
  • [x] Title matches the required conventional commits format, see here
  • [x] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

tonychoe avatar Apr 29 '24 19:04 tonychoe

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 29 '24 19:04 CLAassistant

@dannykopping would you mind to review? this is about your original code for ruler sharding by rule.

tonychoe avatar May 30 '24 01:05 tonychoe