loki icon indicating copy to clipboard operation
loki copied to clipboard

fix(helm): Fix unexisting command argument in ingester statefulset

Open romainDavaze opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

When running Loki in distributed mode and without zone aware replication, the statefulset template sets ingester.ring.instance-availability-zone argument but it not specified in the Loki configuration flags.

This results in ingester pods crashing at startup with the following message:

flag provided but not defined: -ingester.ring.instance-availability-zone
Run with -help to get list of available parameters

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:

Checklist

  • [X] Reviewed the CONTRIBUTING.md guide (required)
  • [] Documentation added
  • [ ] Tests updated
  • [ ] Title matches the required conventional commits format, see here
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [X] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

romainDavaze avatar Apr 23 '24 14:04 romainDavaze

@romainDavaze Please update the other files listed in the checklist. For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

JStickler avatar Apr 23 '24 15:04 JStickler

Done @JStickler

romainDavaze avatar Apr 23 '24 15:04 romainDavaze

I feel like this is probably a bug in loki incorrectly parsing the argument value

TheRealNoob avatar Apr 25 '24 06:04 TheRealNoob