loki icon indicating copy to clipboard operation
loki copied to clipboard

fix(helm): fix queryScheduler servicemonitor

Open rlex opened this issue 1 year ago • 4 comments

What this PR does / why we need it: Loki Query Scheduler had wrong targetPort for metrics port, which caused serviceMonitor to miss it.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

rlex avatar Apr 23 '24 12:04 rlex

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 23 '24 12:04 CLAassistant

Please also bump the version number in production/helm/loki/README.md.

JStickler avatar Apr 23 '24 16:04 JStickler

done

rlex avatar Apr 23 '24 16:04 rlex

Any chance it will be merged? Along with #12766

rlex avatar May 23 '24 13:05 rlex