loki icon indicating copy to clipboard operation
loki copied to clipboard

Published 20 hours ago • verified publisher icon grafana

fix(helm): Disable service monitor for nginx service

Open adinhodovic opened this issue 10 months ago • 4 comments

What this PR does / why we need it: The service monitor that targets all Loki pods targets nginx as well. Nginx isn't configured for prometheus metrics and the endpoint is 404, which causes alerts that the target is down.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
  • [x] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

adinhodovic avatar Apr 23 '24 10:04 adinhodovic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 23 '24 10:04 CLAassistant

Please update the other files listed in the checklist. For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

JStickler avatar Apr 23 '24 16:04 JStickler

Please update the other files listed in the checklist. For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

Makes sense, fixed.

adinhodovic avatar Apr 23 '24 16:04 adinhodovic

Please update the other files listed in the checklist. For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

Anything else needed to move this?

adinhodovic avatar May 20 '24 17:05 adinhodovic

@JStickler Can you merge this small PR?

adinhodovic avatar Jul 02 '24 18:07 adinhodovic

@adinhodovic I'm the technical writer on the team, so I avoid merging code as I'm not a developer.

JStickler avatar Jul 02 '24 18:07 JStickler

@adinhodovic I'm the technical writer on the team, so I avoid merging code as I'm not a developer.

Ah, sorry about the ping!

adinhodovic avatar Jul 02 '24 18:07 adinhodovic