loki icon indicating copy to clipboard operation
loki copied to clipboard

fix: scheduler discovery service may collid with other loki install

Open acolombier opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

This PR fixes a resource conflict which may occurs if you intend to install multiple instances of loki in a same namespace.

Which issue(s) this PR fixes: Fixes conflict introduced in #9477

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [x] Documentation added
  • [ ] ~Tests updated~
  • [x] CHANGELOG.md updated
    • [x] If the change is worth mentioning in the release notes, add add-to-release-notes label
  • [] ~Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md~
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

acolombier avatar Dec 13 '23 17:12 acolombier

Trivy scan found the following vulnerabilities:

github-actions[bot] avatar Dec 13 '23 17:12 github-actions[bot]

We'd also like this to be merged.

vladst3f avatar Feb 20 '24 09:02 vladst3f

@vladst3f could you please put a ":+1: " on the PR? I believe this is hoe the team prioritize community PRs. I will rebase/resolve conflict when the team gives me the green light!

acolombier avatar Feb 20 '24 10:02 acolombier