k6 icon indicating copy to clipboard operation
k6 copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Feature/grpc healthcheck

Open tbourrely opened this issue 5 months ago • 2 comments
trafficstars

What?

Add a healthcheck method to gRPC JS client.

Why?

Remove invoke boilerplate as specified in #3428

Checklist

  • [ ] I have performed a self-review of my code.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests for my changes.
  • [ ] I have run linter and tests locally (make check) and all pass.

Related PR(s)/Issue(s)

Closes #3428

tbourrely avatar Jun 15 '25 23:06 tbourrely

Hello 👋

I would like some feedback on the changes related to issue #3428. Please let me know if I'm going in the wrong direction.

Cheers !

tbourrely avatar Jun 15 '25 23:06 tbourrely

Thanks for the review @codebien 👍 I'll address the js test concerns asap !

tbourrely avatar Jun 20 '25 16:06 tbourrely

I've added the JS client tests. I was unsure whether i should put the healthcheck server on the HTTPMultiBin struct or not 🤔

tbourrely avatar Jun 22 '25 12:06 tbourrely

@tbourrely can you rebase and resolve the conflicts, please?

codebien avatar Jun 25 '25 12:06 codebien