k6 icon indicating copy to clipboard operation
k6 copied to clipboard

Upgraded google.golang.org/grpc v1.64.1 => v1.65.0

Open olegbespalov opened this issue 1 year ago • 1 comments

What?

This updates google.golang.org/grpc, which is nothing significant for the k6, but keeping the change diff tinier is better.

Why?

keeping the change diff tinier is better

Checklist

  • [x] I have performed a self-review of my code.
  • [ ] I have added tests for my changes.
  • [ ] I have run linter locally (make lint) and all checks pass.
  • [ ] I have run tests locally (make tests) and all tests pass.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

olegbespalov avatar Aug 23 '24 15:08 olegbespalov

Maybe run go mod tidy? I guess some lines should be dropped given the CI failure.

mstoykov avatar Aug 24 '24 06:08 mstoykov

Maybe run go mod tidy?

The local go mod tidy using go1.20 showed nothing. If I run this using the go 1.22.6, it produces the diff like 4806b2f. Maybe we should make a separate PR for bringing this toolchain which is now defaults behavior, WDYT?

olegbespalov avatar Aug 26 '24 07:08 olegbespalov

Maybe we should make a separate PR for bringing this toolchain which is now defaults behavior, WDYT

Yeah, that probably is a good idea as I would prefer to have it separate.

Strangely grpc doesn't really specify 1.22 , so I guess we can specifiy 1.21.11 in the toolchain ... but let's discuss this in the separate PR. As I said in hte comment - we likely will upgrade to 1.23 for v0.54.0 either way.

mstoykov avatar Aug 26 '24 07:08 mstoykov