k6 icon indicating copy to clipboard operation
k6 copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Fix metrics for GRPC streams do not correctly include tags when stream ends

Open cchamplin opened this issue 1 year ago • 4 comments

What?

Update the grpc stream being call to pass tags and params that include custom tags and method information

Why?

Addresses https://github.com/grafana/k6/issues/3745

Checklist

  • [X] I have performed a self-review of my code.
  • [X] I have added tests for my changes.
  • [X] I have run linter locally (make lint) and all checks pass.
  • [X] I have run tests locally (make tests) and all tests pass.
  • [X] I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

https://github.com/grafana/k6/issues/3745

Closes #3745

cchamplin avatar May 17 '24 03:05 cchamplin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 17 '24 03:05 CLAassistant

@cchamplin just double-checking if you don't have the capacity for the tests? I could take over; one thing is, could you please maybe name the case? I mean which metrics missed the custom tags? Thanks!

olegbespalov avatar Jun 12 '24 08:06 olegbespalov

Pushing to https://github.com/grafana/k6/milestone/42 while waiting for news.

joanlopez avatar Jun 18 '24 08:06 joanlopez

@olegbespalov @joanlopez I have added the test as requested, let me know if that works.

cchamplin avatar Jun 19 '24 01:06 cchamplin

Hey @cchamplin, Could you try to address what @olegbespalov suggested, please? Once done, I think we'll be ready to merge it. Thanks! 🙇🏻

joanlopez avatar Jul 02 '24 18:07 joanlopez