k6 icon indicating copy to clipboard operation
k6 copied to clipboard

gRPC HealthV1 support without .proto files

Open f0o opened this issue 1 year ago • 2 comments

Feature Description

Currently to check/test gRPC endpoints all .proto files need to be supplied and loaded.

HealthV1 is a well-defined and maintained standard by gRPC workgroup (https://grpc.io/docs/guides/health-checking/ https://github.com/grpc/grpc-proto/blob/master/grpc/health/v1/health.proto) and shouldn't require the end-user (us in this case) to supply the .proto files to check against.

It would be a great quality of life improvement if this standard could be consumed without much preloading the definitions.

Suggested Solution (optional)

Perhaps instead of using client.invoke('MyMethodHere',data) we could add a generic client.healthCheck(serviceName) method which invokes /grpc.health.v1.Health.Check with optional serviceName as parameter.

This could remove a lot of boilerplate code and needless shipping of a standardized .proto file

Already existing or connected issues / PRs (optional)

No response

f0o avatar Oct 28 '23 07:10 f0o

Apologies for the very late reply @f0o 🙇🏻

I think @olegbespalov would be better suited to triage this issue, and will pass the hand onto him 👍🏻

oleiade avatar Dec 20 '23 11:12 oleiade

Hi @f0o!

I'm sorry for not getting back to you sooner. I've skimmed the links that you've provided, and it sounds to me like an improvement :raised_hands:

As a result, I'm removing a triage label from the issue till the following prioritization.

olegbespalov avatar Jan 09 '24 15:01 olegbespalov