k6 icon indicating copy to clipboard operation
k6 copied to clipboard

Switch to snappy framing

Open olegbespalov opened this issue 2 years ago • 1 comments

What?

Switch from the snappy to the snappy framing.

Why?

Closes: #3122

olegbespalov avatar Jun 20 '23 12:06 olegbespalov

Codecov Report

Merging #3134 (c89d2fe) into master (1df72a0) will decrease coverage by 0.05%. The diff coverage is 32.00%.

:exclamation: Current head c89d2fe differs from pull request most recent head d7fb6d2. Consider uploading reports for the commit d7fb6d2 to get more accurate results

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
- Coverage   71.98%   71.94%   -0.05%     
==========================================
  Files         252      252              
  Lines       19405    19427      +22     
==========================================
+ Hits        13969    13977       +8     
- Misses       4542     4553      +11     
- Partials      894      897       +3     
Flag Coverage Δ
ubuntu 71.88% <32.00%> (-0.03%) :arrow_down:
windows 71.79% <32.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/config.go 88.67% <0.00%> (-1.71%) :arrow_down:
output/cloud/expv2/metrics_client.go 46.15% <31.81%> (-13.23%) :arrow_down:
output/cloud/expv2/output.go 66.01% <100.00%> (ø)

... and 4 files with indirect coverage changes

codecov-commenter avatar Jun 28 '23 08:06 codecov-commenter

Closing as deprioritized. If we need this in the future, it could be re-opened.

olegbespalov avatar May 21 '24 06:05 olegbespalov