k6
k6 copied to clipboard
Moving prepareHeaders back to Client.NewRequest
PR #1240 fixes issue #1239 by moving prepareHeaders inside Client.Do
That fixes the issue, but against original discussion.
There're some problems we can see:
Client.NewRequestalways serializes data in JSON forma.- Above reason causes
http.NewRequestmust be used to create POST request with form data.
I propose some solutions:
- Leave
prepareHeadersinsideClient.Doas I proposed before. - Moving
prepareHeadersback toNewRequest, introduce new methodNewRequestWithForm, which will handle POST form data. - Change
Client.NewRequestsignature to get more parameters, something for it to differentiate between json and form data.
The 3rd point will be backward in-compatible.