jsonnet-libs icon indicating copy to clipboard operation
jsonnet-libs copied to clipboard

Consider removing the default `super.withImagePullPolicy('IfNotPresent')` for containers

Open heuristicAL opened this issue 2 years ago • 1 comments

Since k8s now sets the imagePullPolicy automatically upon creation, setting it to IfNotPresent for the container to be valid is not required anymore. https://github.com/grafana/jsonnet-libs/blob/98c3060877aa178f6bdfc6ac618fbe0043fc3de7/ksonnet-util/grafana.libsonnet#L19

Overriding things like this can be cumbersome with jsonnet so it would be nice to not be forcing this on all containers created using the library. Either removing this default entirely or just making the default pull policy value configurable "globally" would be greatly appreciated.

heuristicAL avatar Mar 11 '22 23:03 heuristicAL

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 17:06 stale[bot]