helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[rollout-operator] Replace default webhooks.selfSignedCertSecretName with fullname

Open kimxogus opened this issue 1 month ago • 2 comments

Certificate secret's default name certificate is too general name, so I made it chart's fullname to match with the other resources.

Changing cert secret name doesn't break existing installations. It will recreate rollout-operator pod and cert secret will be recreated as well.

kimxogus avatar Nov 05 '25 11:11 kimxogus

I have double checked that we have the correct permissions for this certificate to be re-created.

This change looks to be safe, but could we just update the values.yaml and/or README/md.gotmpl with additional documentation explaining that the operator can safely update this value if need be.

Is there a specific issue that this generic name is causing? A conflict in the namespace perhaps?

tcp13equals2 avatar Nov 05 '25 23:11 tcp13equals2

@tcp13equals2 Sorry, I was too late. I've just applied suggested changes.

kimxogus avatar Nov 28 '25 08:11 kimxogus