helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard
verified publisher icon grafana

[tempo-distributed] Upgrade to Tempo 2.4.0

Open faustodavid opened this issue 1 year ago • 1 comments

Upgrade Tempo to 2.4.0 and use the new multi-cache config.

I have assigned the following roles to the memcache:

- roles:
    - parquet-footer
    - parquet-column-idx
    - parquet-offset-idx
    - bloom
    - frontend-search

faustodavid avatar Mar 04 '24 22:03 faustodavid

great, looking forward for merge

edgarkz avatar Mar 06 '24 12:03 edgarkz

this lgtm. to be clear i'm not sure that parquet-column-idx and parquet-offset-idx function correctly. i thought i removed them from the tempo docs, but it seems they are still there.

if anyone wants to experiment with these roles to see if tempo does, in fact, use them please do and report back.

joe-elliott avatar Mar 13 '24 15:03 joe-elliott

this lgtm. to be clear i'm not sure that parquet-column-idx and parquet-offset-idx function correctly. i thought i removed them from the tempo docs, but it seems they are still there.

if anyone wants to experiment with these roles to see if tempo does, in fact, use them please do and report back.

for reference we run 3 memcached clusters internally:

  1. frontend-search - small cluster
  2. parquet-footer, parquet-bloom - medium cluster
  3. parquet-pages - large cluster

Hey @joe-elliott, I've removed parquet-column-idx and parquet-offset-idx from this PR, but I will test them in our clusters and let the team know if we see some improvements. I have also refactored this PR to make the cache configurable and added a comment pointing to the docs. Can you review it again, please?

faustodavid avatar Mar 14 '24 19:03 faustodavid

@faustodavid Any chance for merging soon? its already 2 weeks since 2.4 release Thank you

edgarkz avatar Mar 17 '24 15:03 edgarkz

@faustodavid Any chance for merging soon? its already 2 weeks since 2.4 release Thank you

Hi @edgarkz , after @joe-elliott comments I changed the code a bit, so I am waiting for their review.

CC. @zanhsieh

faustodavid avatar Mar 18 '24 12:03 faustodavid

Thanks for the ping. Apologies for missing the first. I'll see if i can get a second +1 from someone internally.

@faustodavid this is great work, thank you!

joe-elliott avatar Mar 18 '24 12:03 joe-elliott

This is breaking change for anyone using external memcached. It should be a major release with migration instructions.

z0rc avatar Mar 19 '24 15:03 z0rc