fix: Push charts to GHCR requires login

[mkilchhofer]

Resolves #2481

OCI chart push was introduced by @jkroepke here:

• https://github.com/grafana/helm-charts/issues/2395
• https://github.com/grafana/helm-charts/pull/2443
• https://github.com/grafana/helm-charts/pull/2474

But it fails due to missing docker login to GHCR.

I am a Argo helm maintainer and we use almost the identical code: https://github.com/argoproj/argo-helm/blob/fa85e824f014ef7bf19163d4ecf7e9b8eb01f6b9/.github/workflows/publish.yml#L67C15-L82

/cc: @zanhsieh as you merged @jkroepke PRs in the past

[CLAassistant]

All committers have signed the CLA.

[jkroepke]

But it fails due to missing docker login to GHCR.

Bruh, really? Thanks for finding this! I overlooked this. Of couse, we have the same code at kube-prometheus-stack, too.

https://github.com/prometheus-community/helm-charts/blob/88472183482b6b7e50a97df2c8286c7ede199eb3/.github/workflows/release.yaml#L45-L61

[mkilchhofer]

Bruh, really?

yaaaa 🥳 😄

[zanhsieh]

@micahhausler Now this repo required at least two approvers to merge by Grafana.

[PlayMTL]

Any updates here? I'm really interested in OCI Charts :)

[benoitschipper]

Same here, would love to be able to pull the charts through OCI directly so I can test the helm charts within kustomize when using flux/argocd :)

[jkroepke]

@Xtigyro @zalegrala Can someone of you please take a look here?

[mkilchhofer]

Ping @krajorama @dimitarvdimitrov @MichelHollands

[meysam81]

any update on this? :pray:

[benoitschipper]

Great Success! 🚀