helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[grafana] fixed url link for persistent volume claim in values.yaml

Open usmangt opened this issue 1 year ago • 5 comments

The old link was using http and was not working. So updated it to https and now it works Signed-off-by: Usman Ahmad [email protected]

usmangt avatar Jan 03 '24 20:01 usmangt

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 03 '24 20:01 CLAassistant

Hi @zanhsieh ,

Can you please provide me the step-by-step instructions as how to sign the DCO?

Also, about bumping the chart version, should I download a new chart on my test-machine?

Apologies, as I am a bit new to these things.

usmangt avatar Jan 07 '24 12:01 usmangt

Can you please provide me the step-by-step instructions as how to sign the DCO? Instruction in below next to DCO (click Details). I put the link here:

https://github.com/grafana/helm-charts/pull/2881/checks?check_run_id=20208007426

Also, about bumping the chart version, should I download a new chart on my test-machine? You just need to change the chart version in Chart.yaml. Downloading a new chart is not needed. https://github.com/grafana/helm-charts/blob/903fff0cdee698f647432c4f8b3f5bc99665db83/charts/grafana/Chart.yaml#L3

zanhsieh avatar Jan 07 '24 16:01 zanhsieh

Signed-off-by: Usman Ahmad [email protected]

usmangt avatar Jan 10 '24 16:01 usmangt

@usmangt The DCO signoff happens during you commit your change, not putting in the PR comment.

zanhsieh avatar Jan 25 '24 01:01 zanhsieh

Hi, please do the following steps on you machine

git rebase HEAD~10 --signoff
git push --force-with-lease origin usmangt-patch-1

jkroepke avatar Jul 30 '24 07:07 jkroepke