helm-charts
helm-charts copied to clipboard
[grafana] fixed url link for persistent volume claim in values.yaml
The old link was using http and was not working. So updated it to https and now it works Signed-off-by: Usman Ahmad [email protected]
Hi @zanhsieh ,
Can you please provide me the step-by-step instructions as how to sign the DCO?
Also, about bumping the chart version, should I download a new chart on my test-machine?
Apologies, as I am a bit new to these things.
Can you please provide me the step-by-step instructions as how to sign the DCO? Instruction in below next to DCO (click Details). I put the link here:
https://github.com/grafana/helm-charts/pull/2881/checks?check_run_id=20208007426
Also, about bumping the chart version, should I download a new chart on my test-machine? You just need to change the chart version in Chart.yaml. Downloading a new chart is not needed. https://github.com/grafana/helm-charts/blob/903fff0cdee698f647432c4f8b3f5bc99665db83/charts/grafana/Chart.yaml#L3
Signed-off-by: Usman Ahmad [email protected]
@usmangt The DCO signoff happens during you commit your change, not putting in the PR comment.
Hi, please do the following steps on you machine
git rebase HEAD~10 --signoff
git push --force-with-lease origin usmangt-patch-1