helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Wrong service target port on image renderer

Open seboudry opened this issue 3 years ago • 1 comments

The target port defined in image renderer service is not the one used on deployment.

Service: https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/image-renderer-service.yaml#L25 Deployment: https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/image-renderer-deployment.yaml#L76

The value imageRenderer.service.targetPort isn't specified on readme but exists on values.yaml.

Two options in order to propose a MR :

  • remove imageRenderer.service.targetPort in favor of imageRenderer.service.port on service: targetPort
  • use imageRenderer.service.targetPorton deployment: containerPort and HTTP_PORT

seboudry avatar Dec 03 '20 18:12 seboudry

It's fixed 🥳 https://github.com/grafana/helm-charts/commit/ce087048ecc833876c63826b9ec2157083ce55be

yyvess avatar Aug 04 '22 16:08 yyvess