grizzly icon indicating copy to clipboard operation
grizzly copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Add option to configure Mimir alertmanager

Open Itaykal opened this issue 1 year ago • 7 comments

fixes #387

This PR fixes some comments, namings and object specific errors (which shouldn't be this specific)

Itaykal avatar May 17 '24 13:05 Itaykal

Thanks for this contribution! We can look at it next week. In the meantime, there's a few lint type things noted in the PR. Can you review them?

malcolmholmes avatar May 17 '24 18:05 malcolmholmes

Thanks for this contribution! We can look at it next week. In the meantime, there's a few lint type things noted in the PR. Can you review them?

Will do when possible, please note that the changes are not final, some tests are missing and some features like list -r are behaving in a weird manner.

Another important note that I think will need some further discussion here is that there's no name and/or uid for such object and I truly don't know how to handle it.

Itaykal avatar May 17 '24 19:05 Itaykal

Another important note that I think will need some further discussion here is that there's no name and/or uid for such object and I truly don't know how to handle it.

How did @theSuess handle it for the equivalent Grafana resource? I think the pattern is already there.

malcolmholmes avatar May 18 '24 20:05 malcolmholmes

How did @theSuess handle it for the equivalent Grafana resource? I think the pattern is already there.

Good point, seems like the implementation is based on having a static name/uid for said object, I could try to align my implementation with theirs.

Itaykal avatar May 18 '24 20:05 Itaykal

Another issue I'm currently having is that pkg/mimir/rules_test.go needs changing as I changed the mimir client, is this test even relevant? I see that the rules are being tested as part of the integration tests under integration/mimir/rules_test.go

Itaykal avatar May 18 '24 21:05 Itaykal

Any chance of resurrecting this PR? We can't use Grizzly for our most common use cases without it. Thank you!

skinlayers avatar Feb 03 '25 09:02 skinlayers

@skinlayers

Any chance of resurrecting this PR? We can't use Grizzly for our most common use cases without it. Thank you!

I don't know if i'll have much time to do that soon :/ Just started a new position and this PR stopped being relevant to me, tough I would like to keep working on it in the future if I get to it.

I'd recommend to checkout from my branch and add the missing pieces

Itaykal avatar Feb 07 '25 22:02 Itaykal