Make stale short link expiry optional

[igorwwwwwwwwwwwwwwwwwwww]

What is this feature?

This expands on the work done by @gelicia in https://github.com/grafana/grafana/pull/86003. It allows stale short link expiry to be disabled by setting short_links.expire_time to a negative value.

Why do we need this feature?

A common pattern is to generate a short link and post it to an issue. This short link may not be accessed right away. Yet we will still want to retain it, in case someone comes looking for it later on.

For this reason, we want the option to disable the link expiry behaviour.

Who is this feature for?

Devs and SREs who use short links to link back to the sources of their analysis in issues and incident reviews.

Which issue(s) does this PR fix?:

• https://community.grafana.com/t/short-link-shows-404-after-some-time/74297
• Related: https://github.com/grafana/grafana/issues/83009

Special notes for your reviewer:

I could use some help actually testing this change, as I don't have a viable testing setup right now.

Please check that:

• [ ] It works as expected from a user's perspective.
• [ ] If this is a pre-GA feature, it is behind a feature toggle.
• [ ] The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[CLAassistant]

All committers have signed the CLA.

[igorwwwwwwwwwwwwwwwwwwww]

@chri2547 I've applied the suggestion. Is anything else needed here?

[mtrin]

This one will be a nice to have :) Thanks for the contribution

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

[igorwwwwwwwwwwwwwwwwwwww]

Another bump to avoid this getting auto-closed.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

[github-actions[bot]]

This pull request has been automatically closed because it has not had any further activity in the last 2 weeks. Thank you for your contributions!

[igorwwwwwwwwwwwwwwwwwwww]

@chri2547 @mtrin Can we get this re-opened and maybe merged?

[chri2547]

@grafana/backend-enterprise @grafana/backend-platform - I'm not sure who should reopen and approve this PR. The docs are fine. Thanks.

[mtrin]

@igorwwwwwwwwwwwwwwwwwwww I don't actually work at Grafana, I believe @chri2547 or @torkelo may be able to reopen

[imatwawana]

hey @igorwwwwwwwwwwwwwwwwwwww, this looks pretty much ready to go, but just needs to clear some checks. Can you rebase or merge with main, please?

[jdbaldry]

I've updated the branch so this looks good to go