grafana icon indicating copy to clipboard operation
grafana copied to clipboard

Show alerting availability in data source details

Open soniaAguilarPeiron opened this issue 2 years ago • 3 comments

What this PR does / why we need it: This PR adds an Alert info in data source details, showing if data source has alerting enabled or not. We think this could help user to understand why this data source does not appear when creating a new alert.

Which issue(s) this PR fixes:

Fixes #51484

Special notes for your reviewer:

I used a Badge for that. Not sure if we should show the badge in case alerting is supported?

This is an example of the result of this PR changes:

Screenshot 2022-08-10 at 09 57 46 Screenshot 2022-08-10 at 09 57 33

soniaAguilarPeiron avatar Aug 08 '22 12:08 soniaAguilarPeiron

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/29123

grafanabot avatar Aug 08 '22 13:08 grafanabot

I agree with Peter's general remark but perhaps we can sidestep the multiple warning messages by using another visualization to show if the data source supports alerting – perhaps a <Badge color="green" icon="check-circle" text="Alerting supported" /> somewhere on the page would work?

gillesdemey avatar Aug 09 '22 11:08 gillesdemey

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/29357

grafanabot avatar Aug 09 '22 15:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/29611

grafanabot avatar Aug 11 '22 08:08 grafanabot

From a Slack chat -- is there a good way to include a link to docs in the warnings, so users who want to understand why only some data sources support Alerting can learn more? https://grafana.com/docs/grafana/latest/alerting/fundamentals/data-source-alerting/

jtheory avatar Aug 11 '22 12:08 jtheory

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/29670

grafanabot avatar Aug 11 '22 13:08 grafanabot