grafana icon indicating copy to clipboard operation
grafana copied to clipboard

AzureMonitor: Added ARG query function for template variables

Open yaelleC opened this issue 2 years ago • 11 comments

What this PR does / why we need it: This PR adds an Azure Resource Graph query function for users to write their own ARG query for generating a template variable.

Screenshot 2022-08-02 at 13 00 39

Which issue(s) this PR fixes:

Fixes #50233

Special notes for your reviewer:

yaelleC avatar Aug 01 '22 16:08 yaelleC

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28456

grafanabot avatar Aug 01 '22 16:08 grafanabot

Backend code coverage report for PR #53059 No changes

github-actions[bot] avatar Aug 02 '22 12:08 github-actions[bot]

Frontend code coverage report for PR #53059

Plugin Main PR Difference
* <rootDir> public app features data-connections mocks store.navIndex.mock.ts * <rootDir> public app features data-connections mocks store.navIndex.mock.ts% * <rootDir> public app features data-connections mocks store.navIndex.mock.ts% %

github-actions[bot] avatar Aug 02 '22 12:08 github-actions[bot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28597

grafanabot avatar Aug 02 '22 12:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28639

grafanabot avatar Aug 02 '22 14:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28658

grafanabot avatar Aug 02 '22 15:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/28939

grafanabot avatar Aug 04 '22 08:08 grafanabot

is the error thing addressed?

andresmgot avatar Aug 04 '22 08:08 andresmgot

@andresmgot Not not yet, I'm still looking into it. I have not found the cause yet, but was able to replicate. Seems like the logs editor and the ARG one are not handling errors the same way.

yaelleC avatar Aug 04 '22 11:08 yaelleC

:+1: What I did for the other types was to catch the error here:

https://github.com/grafana/grafana/blob/7505cf418bcbb286ddc154be0c64fbf4f066584d/public/app/plugins/datasource/grafana-azure-monitor-datasource/variables.ts#L96-L98

Not sure if that applies to this case (I know Logs is currently not showing the error either)

andresmgot avatar Aug 04 '22 11:08 andresmgot

This pull request was removed from the 9.0.7 milestone because 9.0.7 is currently being released.

grafanabot avatar Aug 10 '22 08:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/30765

grafanabot avatar Aug 23 '22 12:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/30779

grafanabot avatar Aug 23 '22 14:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/30824

grafanabot avatar Aug 23 '22 16:08 grafanabot

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/31041

grafanabot avatar Aug 25 '22 07:08 grafanabot

The backport to v9.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-53059-to-v9.0.x origin/v9.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d0d6562f63bf9368dbef2a71d3233960a721b208
# Push it to GitHub
git push --set-upstream origin backport-53059-to-v9.0.x
git switch main
# Remove the local backport branch
git branch -D backport-53059-to-v9.0.x

Then, create a pull request where the base branch is v9.0.x and the compare/head branch is backport-53059-to-v9.0.x.

grafanabot avatar Aug 25 '22 07:08 grafanabot

hey @yaelleC I believe we should change the milestone here to 9.1.1 (and also the backport label)

andresmgot avatar Aug 25 '22 07:08 andresmgot