grafana-zabbix icon indicating copy to clipboard operation
grafana-zabbix copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Parallel query handling

Open iqbalaydrus opened this issue 1 year ago • 4 comments

Solves #1746

iqbalaydrus avatar Nov 15 '23 08:11 iqbalaydrus

Hi @iqbalaydrus, thanks for opening this PR, we are going to take a look at it soon. In the meantime can you please add tests for this?

zoltanbedi avatar Nov 28 '23 10:11 zoltanbedi

I'm not quite sure what tests I should add for parallelization, do you have any suggestions?

iqbalaydrus avatar Nov 30 '23 12:11 iqbalaydrus

I'm not quite sure what tests I should add for parallelization, do you have any suggestions?

I thought you might had an idea how to properly test this. 😅

This needs some more time from us to test properly. And I'm also adding @alexanderzobnin as a reviewer.

zoltanbedi avatar Dec 05 '23 12:12 zoltanbedi

Well parallization just makes things faster without changing any of the app behaviour. So as long as the current tests cover my changes it should be good. But I don't think the tests touch the QueryData method yet. I'll take a look later whether it's possible to add tests to that.

iqbalaydrus avatar Dec 12 '23 02:12 iqbalaydrus

Hi @iqbalaydrus, thank you for contribution. We have decided that currently we don't want to support parallel query handling because of increased complexity. We will keep the issue open in case we revisit this decision later.

ivanahuckova avatar Jul 30 '24 09:07 ivanahuckova