grafana-zabbix icon indicating copy to clipboard operation
grafana-zabbix copied to clipboard

"Item tag" option in query variables doesn't work

Open joachim-vertommen opened this issue 3 years ago • 30 comments

When using Zabbix 5.4 as data source and when defining a variable of the type 'Query', the query option 'Item tag' doesn't work. You can fill in whatever you want or you can leave it empty, it doesn't make a difference. The field just isn't taken into account.

The way it should work is like 'Application' did before Zabbix 5.4.

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
8.1.5 5.4 4.2.4

image

joachim-vertommen avatar Oct 11 '21 12:10 joachim-vertommen

And I encountered the same problem. If I select "Query Type = Item tag", the Item tag works as it should.

drajv-y avatar Oct 21 '21 10:10 drajv-y

Yeah I can definitely confirm this one. With query type "item" the "Item Tag" works as if regex '/.*/' is hard-coded.

niektoniekde avatar Nov 05 '21 20:11 niektoniekde

Can confirm this issue, we are encountering it as well.

Grafana Zabbix Zabbix Grafana plugin
8.2.5 5.4.7 4.2.4

SanderDelden avatar Nov 25 '21 10:11 SanderDelden

Can confirm this issue, we are encountering it as well.

Grafana Zabbix Zabbix Grafana plugin 8.2.5 5.4.7 4.2.4

Same here!

weslley75 avatar Nov 25 '21 11:11 weslley75

Can confirm this issue, we are encountering it as well.

Grafana [v8.3.5] Zabbix 5.4.10 Plugins Zabbix 4.2.3

kakvablyat avatar Feb 14 '22 07:02 kakvablyat

Unfortunately, problem still exists. I filled "Item tag" but there is no "tag" parameter in the query inspector. Tested on "Triggers" query mode.

Grafana v8.4.2 Plugin Zabbix 4.2.5 Zabbix 5.4.9

lpolitowski avatar Mar 02 '22 02:03 lpolitowski

Is there any solution for this?

Grafana v8.5.4 Plugin Zabbix 4.2.8 Zabbix 6.0.3

lucasfnds avatar Jun 07 '22 20:06 lucasfnds

+1

Grafana v9.1.1 Plugin Zabbix 4.2.9 Zabbix 6.2.1

daFlo avatar Aug 29 '22 09:08 daFlo

@alexanderzobnin

As zabbix and Grafana have passed with major version changes, can't you prioritize this problem? because the item tag filter field is very important to improve the performance of the dashboard help us to filter, help please

Grafana v9.1.2 Plugin Zabbix 4.2.9 Zabbix 6.2.1

renatoborges78 avatar Sep 01 '22 01:09 renatoborges78

@alexanderzobnin

I guess the fix is annoying but also we would be really grateful as we use this feature to filter the relevant items quite a lot. Thanks in advance.

Grafana v9.1.7 Plugin Zabbix 4.2.10 Zabbix 6.2.3

daFlo avatar Oct 11 '22 04:10 daFlo

Hi,

Same problem with Zabbix 6.0.9 and Grafana 8.5.5.

OCrylic avatar Oct 11 '22 07:10 OCrylic

Same Problem...

Grafana v9.1.1 Plugin Zabbix 4.2.9 Zabbix 6.2.1

Kerion avatar Oct 18 '22 18:10 Kerion

Same same

Grafana v9.1.1 Plugin Zabbix 4.2.9 Zabbix 6.2.1

thuroc avatar Oct 19 '22 11:10 thuroc

Same problem

Grafana v8.5 Plugin 4.2.10 Zabbix 6.0.9

giovanny07 avatar Oct 19 '22 16:10 giovanny07

Same problem

Grafana v9.1.0 Plugin 4.2.10 Zabbix 6.0.9

lmonasterio-undav avatar Nov 09 '22 18:11 lmonasterio-undav

Same Problem

Grafana 8.4.6 Zabbix 6.2.0 Plugin 4.2.5

jeanfelipenascimento avatar Nov 21 '22 20:11 jeanfelipenascimento

same problem

Grafana v9.1.0 Plugin 4.2.10 Zabbix 6.0.9

mbuyukkarakas avatar Jan 20 '23 08:01 mbuyukkarakas

Same Problem! I can't believe that this elementary problem it is still not fixed! 😱

Grafana 9.3.2 Plugin 4.2.5 Zabbix 5.4.12

maba06 avatar Feb 16 '23 11:02 maba06

I can't believe that this elementary problem it is still not fixed! 😱

Just my humble opinion but this is an open source project mostly run by a single person who also has a day job. I can see why it's not fixed yet. I think we should be thankful for the work he has already done! If it bothers you or you rely on it for business make a fork, fix the problem and make a pull request.

RangersMS avatar Mar 21 '23 17:03 RangersMS

Confirmo que el problema continua usando Grafana 9.4.7 Zabbix 6.4.

Gracias por su atencion.

drkmdaniel avatar May 10 '23 14:05 drkmdaniel

@RangersMS Just my humble opinion but this is an open source project mostly run by a single person who also has a day job. I can see why it's not fixed yet.

I understand your sentiment but this issue is open since Oct, 2021.

Also it's a problem that fixing this would require considerable amount of reverse engineering effort, since it seems that the filtering is not done on the Zabbix API level but in javascript (when one sets Item tag and checks the offered fields in Item it seems that the filtering works then, but when displaying the graph it does not), so it is probably not a simple fix unless you know exactly what to touch.

I haven't found the obvious codepath in 5 minutes, and it was just a preliminary check about how easy this would be to fix. Probably the filtering is written and used in the UI codepath but not in the graph generating one.

Let's hope someone with knowledge of grafana plugin structure and JS will look at it someday.

grinapo avatar May 22 '23 14:05 grinapo

Good news, kind of: I have changed Zabbix datasource from "Browser" to "Server" and the Item Tag filtering now works. Let's call this a workaround…

grinapo avatar May 22 '23 15:05 grinapo

Good news, kind of: I have changed Zabbix datasource from "Browser" to "Server" and the Item Tag filtering now works. Let's call this a workaround…

My datasource settings are already set to "Server" (which is also the recommended setting) - but, I experience the issue anyway. So, unfortunately this isn't a (general) workaround.

Btw., as there is also still issue #1176 open (even already since March 2021), it is a really unsatisfying situation when trying to build more complex dashboards in Grafana using Zabbix as datasource. I very much hope that both issues will now be soon fixed... :-(

maba06 avatar Jul 27 '23 13:07 maba06