grafana-operator icon indicating copy to clipboard operation
grafana-operator copied to clipboard

Allow developer set ephemeral-storage request on grafana instance

Open NissesSenap opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. Today it's only possible to set memory and cpu requests/limits for grafana, I would also want to be able to define ephemeral-storage.

https://github.com/grafana-operator/grafana-operator/blob/8225cdce62a507b2d0d32cb63bb0099fa8680123/controllers/model/grafanaDeployment.go#L52-L66

(If applicable)If your feature request solves a bug please provide a link to the community issue N/A

Describe the solution you'd like Instead of specifying what resources the user can request we could provide the entire requests object and thus getting ephemeral-storage with us. It would also make this solution future-proof, if the kubernetes community come up with some other resource to request/limit then we could just update the library and it should be included.

Describe alternatives you've considered We could also set a sizeLimit in our emptyDir definitions but that would force us as maintainer to know alot about the different disk requirements that grafana might have together with our users requirements.

      emptyDir:
        sizeLimit: 10Mi

Additional context https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#setting-requests-and-limits-for-local-ephemeral-storage

Existing solutions N/A

NissesSenap avatar Oct 21 '21 07:10 NissesSenap

Makes sense, looks like a simple change, so let's prioritise this before the next release

HVBE avatar Oct 26 '21 12:10 HVBE

I see for cpu and memory requests/limits there are default size values what should the defaults be for ephemeral requests/limits? https://github.com/grafana-operator/grafana-operator/blob/8225cdce62a507b2d0d32cb63bb0099fa8680123/controllers/model/grafanaDeployment.go#L17-L26

Bobbins228 avatar Nov 10 '21 15:11 Bobbins228

#613 fixes this

yardenshoham avatar Jan 15 '22 18:01 yardenshoham

This will be solved in version 5, so I close this

NissesSenap avatar Mar 08 '23 15:03 NissesSenap