grafana collection erronously ships node_modules [regression]

[leegarrett]

the grafana collection 6.0.0, as published on galaxy, ships a few thousand nodejs files that should not belong into the release. The previous version is not affected.

Looking at the Makefile, it looks like the build was interrupted mid-build and released as such. Could you reissue a 6.0.1 with the correct build?

[felixfontein]

Please check out https://docs.ansible.com/ansible/devel/dev_guide/developing_collections_distributing.html#ignoring-files-and-folders for how to prevent this to happen again.

Also note that there will be a new ansible-core 2.19.0b3 release tomorrow or beginning of next week, which triggers another Ansible 12.0.0 alpha release. It would be great if a fixed grafana.grafana 6.0.1 release could get included there, instead of reverting back to 5.x.y.

[felixfontein]

Ping @ishanjainn - can you please take a look?

[ishanjainn]

Hey @felixfontein, I have released a new version today (6.0.1), It is in a local CI that was generating node_modules folder from another CI workflow. Ill move this to a GitHub Action over this week as its been causing a few bugs lately to me.

Thanks and appreciate it!

[felixfontein]

@ishanjainn thanks for fixing this! I've downloaded the 6.0.1 tarball, it looks good to me (or at least it didn't contain obvious unexpected things ;) ).

[leegarrett]

Thanks @ishanjainn for the speedy fix!