django-saml2-auth icon indicating copy to clipboard operation
django-saml2-auth copied to clipboard

Allow claims-like attribute keys

Open wrabit opened this issue 5 months ago • 5 comments

Motivation

The current use of dictor to dynamically fetch attribute keys using pathsep='/' interferes with commonly used url-like claim names, i.e. http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name

References:

  • #167

Bumping mr @mostafa as per Contribution notes ;)

wrabit avatar Feb 23 '24 20:02 wrabit

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 23 '24 20:02 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 23 '24 20:02 CLAassistant

One potential change for discussion is using something like '->' for the pathsep instead of '|' to reduce chances someone has it in existing attribute map keys.

wrabit avatar Feb 23 '24 21:02 wrabit

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 09 '24 01:04 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Apr 19 '24 01:04 github-actions[bot]