django-saml2-auth icon indicating copy to clipboard operation
django-saml2-auth copied to clipboard

Fix for #244

Open 73VW opened this issue 1 year ago • 6 comments

Hello @mostafa,

Here's a starting point for a fix for #244.

I am not really sure how I should implement a test for this nor if this is the best way to implement it.

Tell me what do you think about this.

Cheers!

73VW avatar Jan 30 '24 14:01 73VW

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 30 '24 14:01 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mael Pedretti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 30 '24 14:01 CLAassistant

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Mar 16 '24 01:03 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Mar 26 '24 01:03 github-actions[bot]

Hello @mostafa,

Thank you for your reply!

This is a breaking change and I don't know if you want to merge it as is because backwards compatibility won't be ensured. Is that fine for you?

73VW avatar Mar 27 '24 06:03 73VW