clickhouse-datasource icon indicating copy to clipboard operation
clickhouse-datasource copied to clipboard

Span status code not indicating as error in the trace UI

Open nextrevision opened this issue 10 months ago • 0 comments

What happened:

I'm using the latest version of the OpenTelemetry Clickhouse Exporter and have it integrated with Grafana 10.x using the latest Clickhouse datasource version. I can view the trace, but the error icon/indicator does not appear.

What you expected to happen:

When viewing a trace with spans that are of STATUS_CODE_ERROR, I would expect a visual hint.

How to reproduce it (as minimally and precisely as possible):

I think what is missing is a SpanAttribute named error being explicitly set. Since OpenTelemetry doesn't appear to support error as a SpanAttribute through their SDKs, would it be better to key off of the StatusCode column directly?

Screenshots

Below without the indicator:

Screenshot 2024-04-22 at 3 15 00 PM

A query showing the result:

SELECT StatusCode
FROM otel_traces
WHERE SpanId = 'e13714f30858326c'

Query id: 13342227-f21a-4196-8a1b-d970b7211ce5

   ┌─StatusCode────────┐
1. │ STATUS_CODE_ERROR │
   └───────────────────┘

1 row in set.

Environment:

  • Grafana version: 10.4.1
  • Plugin version: Clickhouse 4.0.6
  • OS Grafana is installed on: Linux/Docker
  • User OS & Browser: Firefox
  • Others:

nextrevision avatar Apr 22 '24 22:04 nextrevision