clickhouse-datasource icon indicating copy to clipboard operation
clickhouse-datasource copied to clipboard

Logs volume: update DataSourceWithSupplementaryQueriesSupport implementation

Open matyax opened this issue 1 year ago • 1 comments

In https://github.com/grafana/grafana/pull/80281 the interface was updated to deprecate getDataProvider in favor of getSupplementaryRequest, so data sources that need decoupling from Grafana Core don't depend on queryLogsVolume().

matyax avatar Feb 19 '24 11:02 matyax

Addressing the deprecation should be as simple as renaming getDataProvider to getSupplementaryRequest, and return the request instead of the Observable from queryLogsVolume(), but I see that you have a custom queryLogsVolume implementation that seems to also be doing aggregation and other modifications to the response: https://github.com/grafana/clickhouse-datasource/blob/main/src/data/logs.ts#L75C38-L83

Feel free to ping, I'll be happy to help.

matyax avatar Feb 19 '24 11:02 matyax