clickhouse-datasource icon indicating copy to clipboard operation
clickhouse-datasource copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Better error reporting on query timeout - context deadline exceeded

Open gingerwizard opened this issue 2 years ago • 6 comments

Currently, if the query deadline is exceeded (as controlled by QueryTimeout) in 2.0, the go driver returns a error querying the database: context deadline exceeded error. This isn't particularly clear and basically means the user needs to increase the query timeout (default 60s).

We should catch this specific error and wrap with something to indicate as such.

image

gingerwizard avatar Sep 01 '22 11:09 gingerwizard

note QueryTimeout is in 2.0 only - see https://github.com/grafana/clickhouse-datasource/pull/186

previous versions hardcoded at 30s.

gingerwizard avatar Sep 01 '22 12:09 gingerwizard

This is a client issue. Ill wrap this error in the go-client and PR the plugin when we release the client.

gingerwizard avatar Oct 21 '22 14:10 gingerwizard

@gingerwizard are you able to create a PR for this? Was it fixed?

aangelisc avatar Jun 09 '23 16:06 aangelisc

Hey @gingerwizard - confirming if this issue was fixed and if so, is there a corresponding PR that we can link this issue to?

alyssabull avatar Mar 12 '24 16:03 alyssabull

@alyssabull no, this wasn't fixed yet. @SpencerTorres can you take a look?

jkaflik avatar Mar 12 '24 16:03 jkaflik

@jkaflik yes, I can catch this error and add a clearer message 👍

SpencerTorres avatar Mar 12 '24 16:03 SpencerTorres