carbon-relay-ng
carbon-relay-ng copied to clipboard
The init script in the el6 package does not work and is not necessary
The el6 package (https://packagecloud.io/raintank/raintank/packages/el/6/carbon-relay-ng-0.10.1_135_g7d66c5b-1.x86_64.rpm) comes with two ways to start carbon-relay-ng:
- via upstart with the config
/etc/init/carbon-relay-ng.conf
- via sysV with the script
/etc/init.d/carbon-relay-ng
I've tested starting it via upstart on Centos6 and RHEL6, that works on both.
The script /etc/init.d/carbon-relay-ng
is broken because it points at multiple paths that are non-existent/wrong. It looks to me that this is a script for Ubuntu/Debian because it includes multiple files which exist on Ubuntu but not on Centos/RHEL. So I think we should simply remove the file /etc/init.d/carbon-relay-ng
from the el* packages.
the init script was introduced via #283 :
We're running on aws linux which uses rc style init scripts
does the existence of this script create problems for centos/rhel? at least it seems a bit confusing. perhaps we should build a separate package for aws, or add a header to it describing on which distro's it should work/be used.
It does not cause any technical problems. But on Friday it first confused a user, who then asked us about why it doesn't work, and then Robert and I both also got confused about it. So it should at least be mentioned somewhere.
i think the best solution is:
- confirm aws images indeed deviate from centos/rhel in that they use /etc/init.d/
- create separate package for aws