alloy icon indicating copy to clipboard operation
alloy copied to clipboard

Add static labels support for the AWS Firehose Logs

Open andriikushch opened this issue 9 months ago • 2 comments

PR Description

Adds support for setting some static labels at the AWS configuration level.

Static labels can be set with the X-Amz-Firehose-Common-Attributes header.

Label names should be prefixed with lbl_. Label names and label values should be compatible with a Prometheus data model specification.

Example of the valid X-Amz-Firehose-Common-Attributes value with two custom labels:

{
  "commonAttributes": {
    "lbl_label1": "value1",
    "lbl_label2": "value2"
  }
}

Which issue(s) this PR fixes

N.A.

Notes to the Reviewer

N.A.

PR Checklist

  • [x] CHANGELOG.md updated
  • [x] Documentation added
  • [x] Tests updated
  • [ ] Config converters updated

andriikushch avatar May 02 '24 12:05 andriikushch

Thank you, @clayton-cornell for the suggestions 👍

andriikushch avatar May 06 '24 13:05 andriikushch

Doc content looks OK to me. It's over to @grafana/grafana-alloy-maintainers for code review now :-)

clayton-cornell avatar May 23 '24 17:05 clayton-cornell