alloy icon indicating copy to clipboard operation
alloy copied to clipboard

Work with upstream to make node_exporter integration easier to maintain

Open rfratto opened this issue 2 years ago • 1 comments

grafana/agent#1228 updated our dependency on node_exporter from v1.0.1 to v1.3.1. This ended up being a lot more work than I thought it would be, primarily due to its mapping of YAML to the global kingpin flags node_exporter creates.

It will be easier (and less error prone) to maintain the node_exporter integration in the future if we work with upstream to make the integration easier to maintain. I haven't put a ton of thought into it, but I think this at least removing the usage of unexported globals that configure collectors.

rfratto avatar Jan 06 '22 18:01 rfratto

WIP PR: https://github.com/prometheus/node_exporter/pull/2812

marctc avatar Oct 09 '23 10:10 marctc