Added monitoring.coreos.com/v1 crds

[itspooya]

PR Description

This adds monitoring.coreos.com/v1 crds, more info in issue

Which issue(s) this PR fixes

Fixes #173

Notes to the Reviewer

PR Checklist

• [ ] CHANGELOG.md updated
• [ ] Documentation added
• [ ] Tests updated
• [ ] Config converters updated

[rfratto]

Hey! This is something we've been back and forth on a few times, but I think it's reasonable to start including the CRDs from Prometheus Operator.

I'm worried that copying/pasting them risks us getting out of sync fairly quickly. Instead of copying/pasting them, what would it look like if we added a chart dependency on the official Chart which contains the CRDs? (Even though not all of the CRDs are support in Alloy).

This way, we can allow other tooling to keep us up to date.

[itspooya]

That's a good idea, I saw that before but the question is, do we need all the crds? what are your suggestions on this?

[rfratto]

Given the trade-off between being in sync with upstream and installing some unnecessary CRDs, I'd generally prefer being in sync right now, especially since CRDs are pretty low overheard (IIUC). If this is a problem in the future we can consider rolling back the set of CRDs to just the set we need and figuring out a strategy to not fall out of sync.

[itspooya]

Then based on your answer, I assume I should make a subchart that installs prometheus-operator-crds(add it as dependency), is that right? if it is the case, I will make the changes and then ask you again to review Thanks

[rfratto]

Yes please :)

(I'm OOO next week so it might take a while for me to get back to the review on this, I'm sorry)

[itspooya]

I will do the changes and let you know I am excited about this, thanks for the opportunity

[itspooya]

I have added a line into test part, which would run helm dependency update

[itspooya]

Hi, about the failing CIs, what should I do?