agent
agent copied to clipboard
Feature/mimir.rules.kubernetes externallabels
PR Description
Add support to inject external_labels
to mimir.rules.kubernetes
.
Which issue(s) this PR fixes
Fixes grafana/alloy#356 Fixes grafana/alloy#291
PR Checklist
- [x] CHANGELOG.md updated
- [x] Documentation added
Could this also apply to loki.rules.kubernetes?
Could this also apply to loki.rules.kubernetes?
Sorry about that, during my initial commits, I mistakenly replaced mimir.rules.kubernetes
with loki.rules.kubernetes
. This was an unintentional error, but I have since corrected the commits, and everything now is in order. However, this may have caused some confusion. I want to assure you that the changes were made in error have been rectified, and the commit functionality is only applicable to mimir.rules.kubernetes
, as originally intended.
@tpaschalis is there more to do here?
Please feel free to reach me if any further questions or require additional modifications on this. I'd be delighted to assist and especially interested with the possibility of this into Alloy as well.
Looks good but would love to see some tests here.
This PR has not had any activity in the past 30 days, so the needs-attention
label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention
label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!
Hi, @psychomantys! I opened a PR for Alloy to support this feature. The Alloy PR is based on yours, and credits will go to you in the Alloy changelog. Thank you for your contribution! Since we are no longer adding new features to Grafana Agent, I will close this PR.