agent
agent copied to clipboard
Update payload.go Measurement KeyVals() to handle type in app_agent_receiver
The proposed change was missed in this PR: https://github.com/grafana/agent/pull/5654
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist
- [ ] CHANGELOG.md updated
- [ ] Documentation added
- [ ] Tests updated
- [ ] Config converters updated
@rlankfo As the original author of the PR. @marctc As the review on the original PR.
Would the two of you mind having a look at this PR?
It looks OK to add this since the measurement does include the type in the matching faro.receiver component.
https://github.com/grafana/agent/blob/287b1c68cae77768d70ff20f7d753db943586393/component/faro/receiver/internal/payload/payload.go#L228
@vanugrah Could you please also add a CHANGELOG entry under Enhancements so you can receive the credit due? 🙌
edit: also looks like there's a failing test to fix here.
Hey folks - thanks so much for your review. I have updated the failing test and added a changelog entry. Please let me know if any further changes are required. I think the CI run has has to be approved by an admin.