agent icon indicating copy to clipboard operation
agent copied to clipboard

feat(pyroscope/scrape): remove unused `path_prefix` argument

Open hainenber opened this issue 1 year ago • 4 comments

PR Description

Which issue(s) this PR fixes

Closes grafana/alloy#263

Notes to the Reviewer

PR Checklist

  • [x] CHANGELOG.md updated
  • [x] Documentation added
  • [x] Tests updated

hainenber avatar Feb 08 '24 17:02 hainenber

I asked about this in a comment, but @cyriltovena mentioned that if it doesn't work then that'd be a bug and it'd be worth fixing.

ptodev avatar Feb 09 '24 14:02 ptodev

I'd also +1 trying to wire this in instead.

tpaschalis avatar Feb 19 '24 10:02 tpaschalis

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar Mar 22 '24 00:03 github-actions[bot]

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar May 18 '24 00:05 github-actions[bot]