agent icon indicating copy to clipboard operation
agent copied to clipboard

Add additional service labels

Open m4r1u2 opened this issue 2 years ago • 3 comments

PR Description

Add helm option to set extra service lables.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • [X] CHANGELOG.md updated
  • [X] Documentation added
  • [ ] Tests updated
  • [ ] Config converters updated

m4r1u2 avatar Dec 27 '23 08:12 m4r1u2

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Marius Ensrud seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 27 '23 08:12 CLAassistant

Hey there, thanks for the contribution. Could you explain the rationale behind service layers? Is there a difference than using the normal grafana-agent.labels field here?

tpaschalis avatar Jan 09 '24 16:01 tpaschalis

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it. If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

github-actions[bot] avatar Feb 09 '24 00:02 github-actions[bot]